[mlir][amdgpu] Add amdgpu.make_dma_descriptor #169407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
reviewed
Nov 24, 2025
🐧 Linux x64 Test Results
|
kuhar
reviewed
Nov 24, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
kuhar
reviewed
Nov 25, 2025
kuhar
reviewed
Nov 25, 2025
Co-authored-by: Jakub Kuderski <[email protected]>
krzysz00
reviewed
Nov 26, 2025
krzysz00
approved these changes
Dec 1, 2025
| if (rank != sharedStaticSizes.size()) { | ||
| return emitOpError("tensor must have same rank as tile."); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We should probably check that the atomic barrier is in LDS if it is present (if I'm remembering the conditions correctly)
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! d51853c I will merge after the tests finish and continue working on the comments on the next one. Will ping you when ready :)
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Jakub Kuderski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.